Add pathname which is implicitly referenced #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ruby 3.2.2 - and especially when installing the current `main` version of the Gem via `specific_install` - installing fails because there's an implicit reference to `pathname`: $ gem specific_install thoughtbot/suspenders git version 2.42.0 Installing from [email protected]:thoughtbot/suspenders.git Cloning into '/var/folders/z_/7_lg8ty95s9f7gybbr5_5nqr0000gn/T/d20231013-60937-72rbst'... remote: Enumerating objects: 7101, done. remote: Counting objects: 100% (590/590), done. remote: Compressing objects: 100% (329/329), done. remote: Total 7101 (delta 310), reused 422 (delta 232), pack-reused 6511 Receiving objects: 100% (7101/7101), 1.72 MiB | 3.33 MiB/s, done. Resolving deltas: 100% (3672/3672), done. Invalid gemspec in [suspenders.gemspec]: undefined method `Pathname' for Suspenders:Module ERROR: While executing gem ... (NoMethodError) undefined method `file_name' for nil:NilClass gem_file = file_name || spec.file_name This commit adds `pathname` so that it can be installed.
nickcharlton
requested review from
stevepolitodesign and
thiagoa
as code owners
|
@nickcharlton is this still relevant now that the latest release removed the |
|
I think we can safely close this. I've not been able to test it (and I suspect I won't get around to it any time soon), but I know you've made so many changes it's probably now irrelevant. And I'll just open another if it's still a problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ruby 3.2.2 - and especially when installing the current
mainversion of the Gem viaspecific_install- installing fails because there's an implicit reference topathname:This commit adds
pathnameso that it can be installed.