Remove deprecated CSS tooling. Introduce postcss. #1113
Conversation
|
We might also want to explore removing the following Gems from gem "jsbundling-rails"
gem "cssbundling-rails" |
|
something to consider tomorrow (today? when are you reading this anyway?) deleting template/descriptions/stylesheet_base.md the tests that are failing because they expect to see bourbon in the gemfile.. I think we can just get rid of those, I thought briefly about reversing their polarity to test that bourbon and bitters aren't installed but I talked myself out of it. |
stevepolitodesign
force-pushed
the
1112-simplify-asset-dependencies
branch
2 times, most recently
from
07483b5 to
4eb5ee8
Compare
stevepolitodesign
force-pushed
the
1112-simplify-asset-dependencies
branch
from
4eb5ee8 to
96f0284
Compare
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" /> | ||
| <%%= csrf_meta_tags %> | ||
| <%%= csp_meta_tag %> | ||
|
|
||
| <%%= stylesheet_link_tag "application", "data-turbo-track": "reload" %> | ||
| <%%= javascript_include_tag "application", "data-turbo-track": "reload", defer: true %> |
There was a problem hiding this comment.
I generated a new Rails app without suspenders, and this is what was in application.html.erb.
rails g new_app -c=postcss
templates/Gemfile.erb
Outdated
| @@ -28,7 +25,8 @@ gem "tzinfo-data", platforms: [:mingw, :x64_mingw, :mswin, :jruby] | |||
| <%# gem "webpacker" %> | |||
There was a problem hiding this comment.
I should just remove this now.
| it "adds and configures a bundler strategy for css and js" do | ||
| gemfile = read_project_file("Gemfile") | ||
|
|
||
| expect(gemfile).to match(/bourbon/) | ||
| expect(gemfile).to match(/cssbundling-rails/) | ||
| expect(gemfile).to match(/jsbundling-rails/) | ||
| expect(File).to exist("#{project_path}/postcss.config.js") | ||
| expect(File).to exist("#{project_path}/package.json") | ||
| expect(File).to exist("#{project_path}/bin/dev") | ||
| expect(File).to exist("#{project_path}/app/assets/stylesheets/application.postcss.css") | ||
| expect(File).to exist("#{project_path}/app/javascript/application.js") |
There was a problem hiding this comment.
This ensures the --css=postcss flag did its job.
A future commit should explore if we can remove the Gem all together.
We will probably want to re-order these later
| <% if options[:api] %> | ||
| gem "sprockets", "< 4" |
There was a problem hiding this comment.
We need this for API only mode #1117
🚧 Work in progress
./bin/devscript #1108✅ To-do
cssoption