Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Rails 6.1.0 #1060

Closed
bmack123 opened this issue Dec 28, 2020 · 1 comment · Fixed by #1104
Closed

Update for Rails 6.1.0 #1060

bmack123 opened this issue Dec 28, 2020 · 1 comment · Fixed by #1104
Assignees
@stevepolitodesign

Comments

@bmack123
Copy link

Suspenders currently locks rails to ~> 6.0.0 on the latest version. It would be nice if there was a new version that allowed users of suspenders to update to the latest version of Rails.
@mike-burns mike-burns mentioned this issue Jan 19, 2021
Closed
@stevepolitodesign
Copy link
Contributor

@thiagoa made an excellent point:

One way we could go about that is:

  1. Generate a Suspenders application.
  2. Upgrade it to Rails 6.1.0
  3. Back port the changes to Suspender's source.

If we upgrade a Suspenders-generated app, we can easily take a look at the diff and then back port the changes.

@stevepolitodesign stevepolitodesign self-assigned this Jul 15, 2022
stevepolitodesign added a commit that referenced this issue Aug 5, 2022
@stevepolitodesign
Support Rails 6.1.0
296e3c8 
This commit does the bare minimum to support Rails 6.1.0.

Because the `gem` command is no longer reversible, I opted to replace all
instances with `append_file`. However, #1066 provides a more elegant solution.

Closes #1060
@stevepolitodesign stevepolitodesign mentioned this issue Aug 5, 2022
Merged
stevepolitodesign added a commit that referenced this issue Aug 8, 2022
@stevepolitodesign
Support Rails 6.1.6.1
710b7d7 
This commit does the bare minimum to support Rails 6.1.6.1

Because the `gem` command is no longer reversible, I opted to replace all
instances with `append_file`. However, #1066 provides a more elegant solution.

Closes #1060
stevepolitodesign added a commit that referenced this issue Aug 15, 2022
@stevepolitodesign
Support Rails 6.1.6.1
6409e1b 
This commit does the bare minimum to support Rails 6.1.6.1

Because the `gem` command is no longer reversible, we decided to override the
method by borrowing as much from the [existing
method](https://github.com/rails/rails/blob/04972d9b9ef60796dc8f0917817b5392d61fcf09/railties/lib/rails/generators/actions.rb#L22).
The main difference being that we call `append_file` instead of `gsub_file`, so
that we can preserve reversibility. However, #1066 provides a more elegant
solution.

Closes #1060
stevepolitodesign added a commit that referenced this issue Aug 15, 2022
@stevepolitodesign
Support Rails 6.1.6.1
52f9787 
This commit does the bare minimum to support Rails 6.1.6.1

Because the `gem` command is no longer reversible, we decided to override the
method by borrowing as much from the [existing
method](https://github.com/rails/rails/blob/04972d9b9ef60796dc8f0917817b5392d61fcf09/railties/lib/rails/generators/actions.rb#L22).
The main difference being that we call `append_file` instead of `gsub_file`, so
that we can preserve reversibility. However, #1066 provides a more elegant
solution.

Closes #1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevepolitodesign stevepolitodesign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Rails 6.1.6.1 thoughtbot/suspenders
Rails 6.1.1 thoughtbot/suspenders
2 participants
@stevepolitodesign @bmack123