This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Reinstate class methods #1300
Merged
Reinstate class methods #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested this branch against the latest delayed_paperclip, and/or is it reasonable to assume that the returning of the methods fixes delayed_paperclip? Related: will there be a point release bump of paperclip once this is pulled in? |
|
Yes, I've tested this with delayed_paperclip (by running its tests with paperclip 3.5.0 and again with this branch), and it worked. I will also bump to paperclip 3.5.1 after this is included. |
|
I've merged this in. |
This was referenced Jul 30, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the
<class>.attachment_definitionsmethod to classes, because otherwise the attachments aren't discoverable. Its removal broke delayed_paperclip, too.