Format Failure Message JSON #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
format-errors
branch
from
2eeb901 to
e33b6d3
Compare
This commit modifies the RSpec Matcher to use [`JSON.pretty_generate`][docs] to improve the formatting of JSON bodies and schemata that appear in failure messages. Additionally, the `json-schema` provided error messages have been moved to the top of the failure messages, so that the reasons for failure appear above (potentially lengthy) JSON bodies. [docs]: http://ruby-doc.org/stdlib-2.0.0/libdoc/json/rdoc/JSON.html#method-i-pretty_generate
seanpdoyle
force-pushed
the
format-errors
branch
from
e33b6d3 to
14a474e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the RSpec Matcher to use
JSON.pretty_generateto improve the formatting of JSON bodiesand schemata that appear in failure messages.
Additionally, the
json-schemaprovided error messages have been movedto the top of the failure messages, so that the reasons for failure
appear above (potentially lengthy) JSON bodies.