Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with Rails 5.2 #1146

Merged
merged 2 commits into from
Jun 17, 2018
Merged

Test with Rails 5.2 #1146

merged 2 commits into from
Jun 17, 2018

Conversation

composerinteralia
Copy link
Collaborator

  • Add Rails 5.2 to Appraisal
  • Avoid specifying tiny Ruby versions to reduce churn on .travis.yml

@composerinteralia
Drop specific tiny versions for Ruby
a827630 
This will reduce churn on this file as we try to keep up to date with
TEENY Ruby releases.

Travis installs Ruby via rvm with the --fuzzy flag. They also keep up to
date with the latest releases, so --fuzzy will likely always give us the
latest TEENY release.
mike-burns
mike-burns reviewed Jun 15, 2018
View reviewed changes
Copy link
Contributor

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! One syntax nitpick.

gemfiles/5.2.gemfile
gem "sqlite3", "~> 1.3.10", :platforms => :ruby
gem "activerecord", "~> 5.2.0"

gemspec :name => "factory_bot", :path => "../"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable to ask for Ruby 1.9 hash syntax here?

Copy link
Collaborator Author

@composerinteralia composerinteralia Jun 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appraisal generates this file. I opened an issue there: thoughtbot/appraisal#140

@composerinteralia composerinteralia merged commit 3256842 into master Jun 17, 2018
@composerinteralia composerinteralia deleted the dc-travis branch June 17, 2018 13:08
@teeparham
Copy link

While specifying only the minor ruby version is valid syntax on Travis, it does not in practice return the latest ruby patch version. For example, 2.4 gets version 2.4.1, which is not the latest 2.4 vesrion. See line 432 of https://travis-ci.org/thoughtbot/factory_bot/jobs/392869691 . You're also getting 2.2.7 and 2.3.4. I'm not sure if this is an rvm issue or a Travis issue.

@composerinteralia
Copy link
Collaborator Author

That's too bad. I guess I was mistaken about Travis having the latest patches pre-installed. I would rather not update .travis.yml every couple months for teeny Ruby release. Do you know if there are any good alternatives?

@teeparham
Copy link

I agree this is a bummer, it has been a problem for years, & I don't know of a solution. I found these related Travis issues, but they are unresolved:

travis-ci/travis-ci#5294
travis-ci/travis-ci#7077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burns mike-burns mike-burns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@composerinteralia @teeparham @mike-burns