Move extendedglob from Options.zsh to zshrc #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This option is currently set in dotfiles/zsh/configs/options.zsh Line 6 in d27cceb It used to be set before Perhaps we need to move it before |
|
Seems appropriate given its an option required by the function within I'll update my PR to match. |
_load_settings function requires this to be enabled and is called well before options.zsh is loaded.
rcedwards
changed the title
|
This seems to fix my issue in opdavies/dotfiles#13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This addresses the issue pointed out in #634
Description
Introduced in 46af611, the
_loadSettings()func requiresextendedglob.As such, its been moved from
options.zshto thezshrcfile.