Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test deprecation warnings #1018

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Fix test deprecation warnings #1018

merged 4 commits into from
Aug 9, 2024

Conversation

louis-antonopoulos
Copy link
Contributor

This PR:

  • Addresses two different deprecation warnings that appear when running tests:
DEPRECATION WARNING: The `exist` matcher overrides one built-in by RSpec; 
use `expect(Pathname.new(path)).to exist` instead

DEPRECATION WARNING: Using legacy connection handling is deprecated. 
Please set `legacy_connection_handling` to `false` in your application.

@louis-antonopoulos
Copy link
Contributor Author

I believe CI is failing here due to the issues resolved by #1017.

@louis-antonopoulos
Use Pathname.new in install_generator_spec
42e0e7e 
Fix DEPRECATION WARNING: The `exist` matcher overrides one built-in by RSpec; use `expect(Pathname.new(path)).to exist` instead
@louis-antonopoulos
Disable config.active_record.legacy_connection_handling
99ae3c1 
Fix DEPRECATION WARNING: Using legacy connection handling is deprecated. Please set `legacy_connection_handling` to `false` in your application.
@louis-antonopoulos
Add #get_migration helper
319a081 
Using `Pathname.new` in tests results in a Hound error because of line length.
@sej3506
Only use legacy_connection_handling false for Rails < 7.1
4854a87 
When using the 7.1 gemfile, we get this complaint:
"The `legacy_connection_handling` setter was deprecated in 7.0 and
removed in 7.1, but is still defined in your configuration. Please
remove this call as it no longer has any effect."

This change also sets legacy_connection_handling for Rails versions
before 7.1.
sej3506
sej3506 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sej3506 sej3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏🏻

@sej3506 sej3506 merged commit 87bca53 into main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sej3506 sej3506 sej3506 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-antonopoulos @sej3506