Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from Aruba? #18

Merged
merged 7 commits into from
May 4, 2018
Merged

Move away from Aruba? #18

merged 7 commits into from
May 4, 2018

Conversation

odlp
Copy link
Contributor

@odlp odlp commented Apr 27, 2018

The build on master is currently broken - I think this is because the Aruba / Cucumber @disable-bundler hint has been broken in recent releases.

I've used Aruba for a while now, but would like to suggest a simpler alternative. I think Aruba grown overly complex (supporting Cucumber, RSpec, Minitest etc) and buggy. They've also deprecated the functionality to run tests in a directory outside your project structure (like /tmp/x) which isn't helpful when one wants to write tests with commands like git init and rails new etc.

Summary of changes:

  • Remove Aruba / Cucumber / Turnip etc
  • Rewrite specs in plain RSpec with JetBlack (new gem I've been working on!)
  • Removes rails & it's dependencies as a development dependencies of the gem
  • Bumps Travis from Ruby 2.2 (now EOL) to 2.3, 2.4 and 2.5


RSpec.describe "Using Discoball in a Rails app" do
let(:session) do
JetBlack::Session.new(options: { clean_bundler_env: true } )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/SpaceInsideParens: Space inside parentheses detected.

Copy link
Contributor

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely an improvement. LGTM.

(I wouldn't mind more YARD doc around jet_black, BTW.)

install_success_api

setup_controller_action(<<~RUBY)
render :plain => SuccessAPI.get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to use Ruby 2 hash syntax here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout. I copied these directly from the previous test implementation, but this is a good chance to update them.

@mvz
Copy link

mvz commented Apr 27, 2018

FWIW, @disable-bundler is only broken in the 1.0 pre-releases of Aruba, and should work fine in the 0.14.5 release you're using. Something else must be causing those build failures.

Handling of absolute paths is a bit of a mess at the moment. The current plan is to continue to allow it, but give a warning that can be turned of.

@odlp
Copy link
Contributor Author

odlp commented May 3, 2018

@mvz thanks for the clarification. I did try a couple of different versions but still saw bundler related errors.

@odlp odlp merged commit 5d416c9 into master May 4, 2018
@odlp odlp deleted the op-jet-black branch May 4, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants