-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from Aruba? #18
Conversation
We can run rails commands by creating a Gemfile in the black box test
spec/black_box/rails_app_spec.rb
Outdated
|
||
RSpec.describe "Using Discoball in a Rails app" do | ||
let(:session) do | ||
JetBlack::Session.new(options: { clean_bundler_env: true } ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/SpaceInsideParens: Space inside parentheses detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely an improvement. LGTM.
(I wouldn't mind more YARD doc around jet_black, BTW.)
install_success_api | ||
|
||
setup_controller_action(<<~RUBY) | ||
render :plain => SuccessAPI.get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to use Ruby 2 hash syntax here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout. I copied these directly from the previous test implementation, but this is a good chance to update them.
FWIW, Handling of absolute paths is a bit of a mess at the moment. The current plan is to continue to allow it, but give a warning that can be turned of. |
@mvz thanks for the clarification. I did try a couple of different versions but still saw bundler related errors. |
The build on
master
is currently broken - I think this is because the Aruba / Cucumber@disable-bundler
hint has been broken in recent releases.I've used Aruba for a while now, but would like to suggest a simpler alternative. I think Aruba grown overly complex (supporting Cucumber, RSpec, Minitest etc) and buggy. They've also deprecated the functionality to run tests in a directory outside your project structure (like
/tmp/x
) which isn't helpful when one wants to write tests with commands likegit init
andrails new
etc.Summary of changes:
rails
& it's dependencies as a development dependencies of the gem2.2
(now EOL) to2.3
,2.4
and2.5