This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Ignore custom fonts applied to pseudo elements #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebPage::setUserStylesheet prevents Web Fonts from loading when styles are applied directly to elements, however if the styles are applied to pseudo elements, the override does not apply. This leads to crashes on Mac OS X, likely due to https://bugs.webkit.org/show_bug.cgi?id=61031.
|
Updated to apply to all pseudo elements, not just before and after. |
| @@ -1326,6 +1332,38 @@ def make_the_server_go_away | |||
| SCRIPT | |||
| font_family.should == "Arial" | |||
| end | |||
|
|
|||
| it "ignores custom fonts before an element" do | |||
| font_family = driver.evaluate_script(<<-SCRIPT) | |||
There was a problem hiding this comment.
There's some duplication in these examples. You could extract a helper method to get the computed style; I think the only variation between the examples is the pseudo-selector (before, after, etc).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebPage::setUserStylesheet prevents Web Fonts from loading when styles
are applied directly to elements, however if the styles are applied to
pseudo elements, the override does not apply. This leads to crashes on
Mac OS X, likely due to https://bugs.webkit.org/show_bug.cgi?id=61031.
Fixes #181.