Small fixes for Go cross-compilation and plz-watch. #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use GOARCH=amd64 when ARCH is x86-64. - Don't cease watching when a target's execution context is terminated before the target can be started.
|
Hey @peterebden - Just wanted to ping this one, in case it slipped your notice. Do these changes look reasonable to you? Would be great to see these fixes merged and released alongside the other recently merged PRs. Thanks in advance for taking a look! |
|
Sorry, yes, it had :) Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOARCHofamd64whenARCHisx86-64.Total mystery as to why
--arch=linux_x86-64was ever working with Go in the first place, for me..