plz/watch: Increase debounce interval to prevent double-builds. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With one of my services I'm testing with, I noticed that the service would sometimes be restarted twice, for one file-change. Doubling the debounce interval seems to fix the issue.
katzdm
force-pushed
the
increase-debounce
branch
from
f2ee222
to
2549ad6
Compare
|
I was able to reproduce this issue locally on my Mac, but resolved it by:
Seems like this test failure is maybe a problem with the CircleCI Docker image, though? Some research suggests that adding Not sure why this is just happening now, though :-) |
|
Computers, huh :) This change makes sense, anyway. There's obviously a tradeoff but 100ms is still pretty reasonable, given there isn't an obviously better way of resolving the actual problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With one of my services I'm testing with, I noticed that the service would sometimes be restarted twice, for the same file-change. Doubling the debounce interval fixes the issue.