Multiple improvements to "plz watch" and "plz run". #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzdm
force-pushed
the
watch-servers
branch
3 times, most recently
from
fd40a1b
to
a537807
Compare
|
@peterebden I saw you aimed for a similar class of fixes with 594a0e - There are some issues with the approach there; I left a comment on the commit. Going to keep this open for the time being, just until we have that worked out. |
|
Sorry, I missed this one! Will follow up on the commit thread. |
katzdm
referenced
this pull request
Apr 19, 2019
Interestingly they now seem to be getting a SIGINT when I ctrl+c the parent, although I haven't done anything explicit to handle that?
- Create a parent context above all target-contexts; cancel it on SIGINT - Launch a goroutine to watch for ctx.Done() for each target started. Kill its process-group when it happens.
|
Nice, I like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParallelorSequential(includingwatch --run) onSIGINTwatch" on running targets. Instead, restart targets on notificationThis is a follow-up on #599.