Don't compare unexported fields when comparing subrepos #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two subrepos can be equal even if their unexported `fs` and `fsSync` fields differ. Exclude them when checking the equality of two subrepos. Fixes thought-machine#3222.
peterebden
approved these changes
Aug 15, 2024
chrisnovakovic
added a commit
to chrisnovakovic/go-rules
that referenced
this pull request
Aug 15, 2024
This should fix a bug that is blocking the go-rules release pipeline (see thought-machine/please#3223).
chrisnovakovic
added a commit
to chrisnovakovic/go-rules
that referenced
this pull request
Aug 15, 2024
This should fix a bug that is blocking the go-rules release workflow (see thought-machine/please#3223).
chrisnovakovic
added a commit
to please-build/go-rules
that referenced
this pull request
Aug 15, 2024
This should fix a bug that is blocking the go-rules release workflow (see thought-machine/please#3223).
|
Nice! I think this might have been the issue I was hitting when trying to cross compile recently. Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two subrepos can be equal even if their unexported
fsandfsSyncfields differ. Exclude them when checking the equality of two subrepos.Fixes #3222.