Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message and rename variables to clarify what they are #3216

Merged

Conversation

goddenrich
Copy link
Contributor

@goddenrich goddenrich commented Aug 11, 2024

previously we were

t := graph.WaitForTarget(l)
if t == nil {
			return fmt.Errorf("... (provided by %s), ...", ..., t)

which was not helpful given it will be nil. What I believe was intended was to put the target resolve in line one of the function

t := graph.WaitForTarget(*dep.declared)

which was being masked within the for loop. I have made this change and renamed the variables to be clearer

@goddenrich goddenrich merged commit f687927 into thought-machine:master Aug 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants