Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nicer version of #3150; it should fix the same problem in a more principled way.
Repeating the context here:
//a
and//b
, both of which are preloaded.//a
containssubinclude("//b")
.//b
contains a syntax errorWe never exit from RegisterPreloads; the errgroup has the error from
//b
but is waiting for//a
to complete, which it never does.This fixes it by propagating the error through the map where the caller is waiting, so they can receive it too; it extends it from "get the thing or wait" to "get the thing or the error, or wait". I think this should be a more generic solution to this kind of thing overall.