Allow 'default' entry in provide map for when there's no match #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatskaari
force-pushed
the
default-provide
branch
from
ef60d42
to
ae36b7d
Compare
…quire doesn't match
Tatskaari
force-pushed
the
default-provide
branch
from
ae36b7d
to
3269527
Compare
Tatskaari
commented
Apr 24, 2024
src/core/build_target.go
Outdated
Comment on lines
567
to
568
| // TODO(jpoole): shouldn't this use the ProvideFor wrapper that handles resolving to self if there's no match? | ||
| labels := t.provideFor(target, ffDefaultProvide) |
There was a problem hiding this comment.
This probably requires a bit of thought
peterebden
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3140 this should allow us to default to no dependency when the require can't be satisfied, which would be nice in a number of circumstances.