unit-ilo-edit-modal Component Review #526
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ontrack Component Review
Team Member Name
Ivan Justin
Student ID: s223844277
Component Name
UnitILOEditComponent
Files in this Component:
unit-ilo-edit-modal.coffee
unit-ilo-edit-modal.tpl.html
Component Purpose
The primary purpose of the
UnitILOEditModalComponent
is to provide the user (a tutor or a convenor) the ability to insert and edit ILOs that match the units that they oversee. It includes the ability to add new ILOs, the ability to give them names, abbreviations, and descriptions, as well as data from pre-existing ILOs.Screenshots:
Original (PDF):
Component Outcomes and Interactions
Expected Outcomes:
Interactions:
Inputs:
ilo
: Object containing the data of the ILO in question, including its name, its abbreviation, and its description.prototypeIlo
: Object to store user inputs.Outputs:
LearningOutcomeService
object which will store and associate the new ILO with the certain unit ID.Component Migration Plan
Migration Steps:
I will be following
doubtfire-web's Migration Guide
Analyze Existing Component:
Setup Angular Environment:
Create Angular Component:
Integrate Services:
UnitILOEditModalService
into the new Angular component.Downgrade Component:
UpgradeModule
to downgrade the Angular component for use in the AngularJS app.Testing:
Component Review Checklist
Ability to collect details from the user
Succeeds when data is valid
Handles errors
Created unit is shown on success