Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create thoth-tech-worklog-guideline.md #16

Closed
wants to merge 24 commits into from

Conversation

ivanhub7
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • [✓ ] Documentation (update or new)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • [✓ ] My code follows the style guidelines of this project
  • [✓ ] I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for strong-fairy-c1bde1 failed.

Name Link
🔨 Latest commit 704572a
🔍 Latest deploy log https://app.netlify.com/sites/strong-fairy-c1bde1/deploys/657bb18d175b55000873f034

Copy link
Contributor

@Kachi-Okorie Kachi-Okorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed the CI Build checks.
On your terminal, run "npm install prettier" and ensure you have the extension installed.
Then right click the created document and select format document with Prettier

@Kachi-Okorie
Copy link
Contributor

All checks passed. Good to go

@Kachi-Okorie Kachi-Okorie requested a review from abkenar November 23, 2023 06:10
@Kachi-Okorie
Copy link
Contributor

Your last commit has lint error on how-to-publish-an-astro-website-to-netlify-guide.md file

@Kachi-Okorie
Copy link
Contributor

Changes looks good. Please follow up with Amin to approve

@Kachi-Okorie
Copy link
Contributor

@ivanhub7 as mentioned during the Standup. Create a netlify account and host the Documentation website on there to be able to generate the appropriate steps for the document.

@Kachi-Okorie
Copy link
Contributor

@ivanhub7
Copy link
Author

@ivanhub7
Copy link
Author

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for thoth-tech failed.

Name Link
🔨 Latest commit 704572a
🔍 Latest deploy log https://app.netlify.com/sites/thoth-tech/deploys/657bb18d3cab97000831d54f

@Kachi-Okorie
Copy link
Contributor

Always read the details of your failed checks

@ivanhub7
Copy link
Author

@ivanhub7 ivanhub7 closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants