Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated virtualenv #610

Closed
wants to merge 1 commit into from
Closed

Updated virtualenv #610

wants to merge 1 commit into from

Conversation

saisankargochhayat
Copy link
Contributor

Related Issues and Dependencies

Update virtualenv to fix errors like -
thoth-station/thamos#624

Reference - pypa/pipenv#4476 (comment)

@sesheta
Copy link
Member

sesheta commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pacospace after the PR has been reviewed.
You can assign the PR to them by writing /assign @pacospace in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested a review from KPostOffice November 23, 2020 14:35
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2020
@saisankargochhayat
Copy link
Contributor Author

/deploy

@saisankargochhayat
Copy link
Contributor Author

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020
@saisankargochhayat
Copy link
Contributor Author

Might not be necessary, will test with 1.1.3

@saisankargochhayat
Copy link
Contributor Author

Closing this as the importlib issue is not happening anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex Awaiting requested review from fridex

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@goern goern Awaiting requested review from goern

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saisankargochhayat @sesheta