Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce horus magic commands #356

Merged
merged 12 commits into from
Aug 3, 2021
Merged

Introduce horus magic commands #356

merged 12 commits into from
Aug 3, 2021

Conversation

pacospace
Copy link
Contributor

@pacospace pacospace commented Jul 19, 2021 •
edited
Loading

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
@pacospace pacospace changed the title WIP: Introduce magic commands WIP: Introduce horus magic commands Jul 19, 2021
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2021
@pacospace pacospace force-pushed the feature/magic-commands branch 5 times, most recently from baacc9e to 7e74af2 Compare July 21, 2021 15:58
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2021
@pacospace pacospace force-pushed the feature/magic-commands branch from 7e74af2 to da56485 Compare July 21, 2021 16:14
@sesheta
Copy link
Member

sesheta commented Jul 26, 2021

@pacospace: The label(s) kind//priority, kind/important-soon cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature /priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2021
@pacospace
Copy link
Contributor Author

pacospace commented Jul 27, 2021 •
edited
Loading

it requires jupyterlab 3.1.0: jupyterlab/jupyterlab#10513 for the specific feature on message sent after cell executed.

Francesco Murdaca added 4 commits July 27, 2021 15:22
WIP: Introduce magic commands
ea015ff 
Signed-off-by: Francesco Murdaca <[email protected]>
Add nbextension entry points
519c950 
Signed-off-by: Francesco Murdaca <[email protected]>
Add check magic command
58919c6 
Signed-off-by: Francesco Murdaca <[email protected]>
Add horus requirements magic command
ef77f4e 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the feature/magic-commands branch from da56485 to ef77f4e Compare July 27, 2021 13:34
add horus show magic command
feafec6 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace mentioned this pull request Jul 27, 2021
Open
Adjust instantiation of horus magic commands and use feature for noti…
5deab54 
…fication when to save content

Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2021
Add horus lock magic command
27546d9 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the feature/magic-commands branch from 1c38897 to 27546d9 Compare July 29, 2021 16:31
@pacospace pacospace force-pushed the feature/magic-commands branch from 97c4d0e to 0c37108 Compare July 30, 2021 14:03
@pacospace pacospace force-pushed the feature/magic-commands branch from 70ac908 to de8cd11 Compare July 30, 2021 14:16
Add horus discover magic command
296b80b 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the feature/magic-commands branch from 2f34a7e to 296b80b Compare July 30, 2021 14:42
Add horus extract magic command
b07a867 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace
Copy link
Contributor Author

/retest

@pacospace pacospace force-pushed the feature/magic-commands branch 5 times, most recently from ca016b7 to 3691ccc Compare July 30, 2021 16:02
@pacospace
Copy link
Contributor Author

/retest

@pacospace pacospace changed the title WIP: Introduce horus magic commands Introduce horus magic commands Jul 30, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2021
@pacospace pacospace force-pushed the feature/magic-commands branch 6 times, most recently from d370876 to 7d90b77 Compare August 3, 2021 10:32
Update README
78fb5b2 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the feature/magic-commands branch from 7d90b77 to 78fb5b2 Compare August 3, 2021 10:40
@pacospace
Copy link
Contributor Author

/approve

@sesheta
Copy link
Member

sesheta commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@sesheta sesheta merged commit e4873d2 into thoth-station:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex Awaiting requested review from fridex

@goern goern Awaiting requested review from goern

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can we do the dependency management in a cell?
2 participants
@pacospace @sesheta