Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Resolve: [Swap] Fix slip calculation and displaying #1876

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Resolve: [Swap] Fix slip calculation and displaying #1876

merged 3 commits into from
Oct 25, 2021

Conversation

gromxyz
Copy link
Contributor

@gromxyz gromxyz commented Oct 25, 2021 •
edited
Loading

Screenshot 2021-10-25 at 10 38 41

Closes #1870

@gromxyz gromxyz requested a review from veado October 25, 2021 08:33
@gromxyz gromxyz self-assigned this Oct 25, 2021
veado
veado suggested changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find + nice fix! Just a nitpick ...

src/renderer/components/swap/Swap.utils.ts Outdated Show resolved Hide resolved
src/renderer/components/swap/Swap.utils.ts Outdated Show resolved Hide resolved
src/renderer/components/swap/Swap.utils.ts Show resolved Hide resolved
veado
veado approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gromxyz gromxyz merged commit 25afcf8 into develop Oct 25, 2021
@gromxyz gromxyz deleted the issue-1870/fix-slip-percentage branch October 25, 2021 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@veado veado veado approved these changes

Assignees

@gromxyz gromxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slip always shows 0%
2 participants
@gromxyz @veado