Prepare `thorchain-ledger` integration #1643

veado · 2021-07-21T19:00:00Z

Use @thorchain/ledger-thorchain + @ledgerhq/hw-transport-node-hid-singleton
Use webpack-node-externals (similar to webpack config of ledger-live-desktop) to avoid error ""Cannot read property 'indexOf'" by using hw-transport-node-hid (or hw-transport-node-hid-singleton).
Enable com.apple.security.cs.disable-library-validation flag to fix macOS error "not valid for use in process using Library Validation: mapped file has no cdhash, completely unsigned? Code has to be at least ad-hoc signed" (see Executables within app.asar.unpacked are not being signed correctly in OSX 10.14.5 electron-userland/electron-builder#3940 (comment) or entitlements.plist of ledger-live-desktop)
Provide useLedger hook
Extract toClientNetwork to shared folder
Provide index parameter needed for derivation path

- `thorchain-ledger` needs to be linked locally (via `yarn link`) to run / build all code

similar to `ledger-desktop-live` https://github.com/LedgerHQ/ledger-live-desktop/blob/67d6fa938f51413fcd0d1d09661e839ee8aaf459/tools/main.js#L141

See electron-userland/electron-builder#3940 (comment) Similar to `ledger-live-desktop` https://github.com/LedgerHQ/ledger-live-desktop/blob/766fdf662b78d1d9824367687a5ffe725feef730/build/mac/entitlements.plist#L9

- Make `useLedger` more generic `chain` + `index`) - Add `GetLedgerAddressArgs` - Remove `getTransport` from `ApiHDWallet` - Support `index` for path - Extract `toClientNetwork` to `shared/...`

veado · 2021-08-12T12:23:38Z

Close in favour of #1655

veado added 5 commits July 20, 2021 19:48

WIP: Try webusb - currently failing

79ffafc

- `thorchain-ledger` needs to be linked locally (via `yarn link`) to run / build all code

WIP: thorchain-ledger + hid-singleton

2082d28

Try webpack-node-externals

8882ea9

similar to `ledger-desktop-live` https://github.com/LedgerHQ/ledger-live-desktop/blob/67d6fa938f51413fcd0d1d09661e839ee8aaf459/tools/main.js#L141

Add disable-library-validation to *.plist

7c4d739

See electron-userland/electron-builder#3940 (comment) Similar to `ledger-live-desktop` https://github.com/LedgerHQ/ledger-live-desktop/blob/766fdf662b78d1d9824367687a5ffe725feef730/build/mac/entitlements.plist#L9

Clean up

43c0397

- Make `useLedger` more generic `chain` + `index`) - Add `GetLedgerAddressArgs` - Remove `getTransport` from `ApiHDWallet` - Support `index` for path - Extract `toClientNetwork` to `shared/...`

veado self-assigned this Jul 21, 2021

veado closed this Aug 12, 2021

veado deleted the issue-1570/try-hid-singleton branch August 12, 2021 12:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare `thorchain-ledger` integration #1643

Prepare `thorchain-ledger` integration #1643

veado commented Jul 21, 2021 •

edited

Loading

veado commented Aug 12, 2021

Prepare thorchain-ledger integration #1643

Prepare thorchain-ledger integration #1643

Conversation

veado commented Jul 21, 2021 • edited Loading

veado commented Aug 12, 2021

Prepare `thorchain-ledger` integration #1643

Prepare `thorchain-ledger` integration #1643

veado commented Jul 21, 2021 •

edited

Loading