Skip to content

Commit

Permalink
Use older base image for sanitizer and fuzz testing.
Browse files Browse the repository at this point in the history
The latest ubuntu seems to break sanitizers/fuzz testing, so use an older
version for the time being to get the tests back online.

Make sure the Swift image matches also just for safety sake.

Fixes apple#1571 & apple#1573
  • Loading branch information
thomasvl committed Mar 18, 2024
1 parent 3947444 commit b07c950
Showing 1 changed file with 14 additions and 6 deletions.
20 changes: 14 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,19 @@ jobs:
run: swift package diagnose-api-breaking-changes origin/main --products SwiftProtobuf

sanitizer_testing:
runs-on: ubuntu-latest
# Using older ubuntu image due to issue with newer linux kernel images. When
# changing, see the "container" value below.
# https://github.com/apple/swift-protobuf/issues/1571
runs-on: ubuntu-20
strategy:
fail-fast: false
matrix:
sanitizer: ["address", "thread"]
swiftpm_config: ["debug", "release"]
container:
# Test on the latest Swift release.
image: swift:latest
# Test on the latest Swift release, but forcing the focal image to match the
# ubuntu issue mentioned aboce.
image: swift:focal
steps:
- uses: actions/checkout@v4
- name: Test
Expand All @@ -163,14 +167,18 @@ jobs:
swift test -c ${{ matrix.swiftpm_config }} --sanitize=${{ matrix.sanitizer }} ${EXTRAS:-}
fuzzing_regressions:
runs-on: ubuntu-latest
# Using older ubuntu image due to issue with newer linux kernel images. When
# changing, see the "container" value below.
# https://github.com/apple/swift-protobuf/issues/1571
runs-on: ubuntu-20
strategy:
fail-fast: false
matrix:
swiftpm_config: ["debug", "release"]
container:
# Test on the latest Swift release.
image: swift:latest
# Test on the latest Swift release, but forcing the focal image to match the
# ubuntu issue mentioned aboce.
image: swift:focal
steps:
- uses: actions/checkout@v4
- name: Build
Expand Down

0 comments on commit b07c950

Please sign in to comment.