Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: additional checks for card editor entities array #277

Closed
wants to merge 12 commits into from

Conversation

flixlix
Copy link
Contributor

@flixlix flixlix commented Apr 15, 2023

This resolves my issue #275
Adds Additional checks in the editor. Checks if entities is actually an array before trying to do anything.

.gitignore Outdated Show resolved Hide resolved
@flixlix
Copy link
Contributor Author

flixlix commented Jun 8, 2023

Reverted the changes unrelated to the PR

@dzedler
Copy link

dzedler commented Sep 14, 2023

Can someone review and accept the PR, please? I am affected by the bug this causes.

@Yorkie71
Copy link

Yorkie71 commented Oct 4, 2023

Hi @thomasloven may I ask what the current status is with this task please as it would be really useful to have this approved so that the UI becomes available in the excellent power flow card that @flixlix has created. Thanks.

@DanielWeeber
Copy link

Hey @thomasloven same here, please have a look at it

@zanac
Copy link

zanac commented Oct 27, 2023

When will be merged? This is a great PR

@marksie1988
Copy link

Any news on getting this merged? this will also help me with a similar issue

@thomasloven
Copy link
Owner

I had to do some massaging offline to get this to merge.

It's merged in e7405bf

Thanks a lot! And I'm really sorry this has caused issues for you and that I've been so slow to respond.

@Yorkie71
Copy link

Thanks @thomasloven I have just updated and now I see the GUI and Power Card Plus. Super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants