Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked project structure #5

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Conversation

Icekey
Copy link
Contributor

@Icekey Icekey commented Mar 23, 2023

  • Tesseract output gets captured directly instead of parsing it from a file
  • added TSV output

- Tesseract output gets captured directly instead of parsing it from a file
- added TSV output
@thomasgruebl
Copy link
Owner

Hi,

thanks for reworking the project structure!

I'm getting the following errors when I run it:

`
error[E0658]: use of unstable library feature 'command_access'
--> src/tesseract/command.rs:76:10
|
76 | .get_args()
| ^^^^^^^^
|
= note: see issue #44434 rust-lang/rust#44434 for more information

error[E0658]: use of unstable library feature 'command_access'
--> src/tesseract/command.rs:83:17
|
83 | command.get_program().to_str().unwrap(),
| ^^^^^^^^^^^
|
= note: see issue #44434 rust-lang/rust#44434 for more information

For more information about this error, try rustc --explain E0658.
error: could not compile rusty-tesseract due to 2 previous errors
`

@Icekey
Copy link
Contributor Author

Icekey commented Mar 26, 2023

Are you using an old rust version? The function "get_args" is stable since 1.57.0. I always use the newest version of rust so i did not notice. What version should the libary target?

@thomasgruebl
Copy link
Owner

Oh yeah, thanks, might be my current version. I'll update and review the PR asap.

@thomasgruebl thomasgruebl merged commit d59e462 into thomasgruebl:main Mar 26, 2023
@Icekey
Copy link
Contributor Author

Icekey commented Mar 26, 2023

Thank you for merging. If you have suggestions please let me know. I am pretty much done with the rework. Only thing i feel that could be better is the error messaging and documentation of the crate with a https://docs.rs/ site like https://docs.rs/image/0.24.6/image/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants