Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI.yml #3

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Update CI.yml #3

merged 2 commits into from
Jul 2, 2024

Conversation

NiharR27
Copy link
Contributor

@NiharR27 NiharR27 commented Jul 2, 2024

Updating to get rid of warning on ci related to node version

@NiharR27
Copy link
Contributor Author

NiharR27 commented Jul 2, 2024

Hi @thomaseizinger when you get some time, can we get this in?
I am seeing this warning on ci:

Publish new release
The following actions uses node12 which is deprecated and will be forced to run on node16: thomaseizinger/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Happy to make any changes if required.

Thanks 🙏🏽

Copy link
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this it won't change the node version that this action currently requires. For that, you need to patch action.yml

@thomaseizinger thomaseizinger merged commit d75036a into thomaseizinger:master Jul 2, 2024
@NiharR027 NiharR027 mentioned this pull request Jul 2, 2024
@NiharR027
Copy link

NiharR027 commented Jul 2, 2024

Happy to merge this it won't change the node version that this action currently requires. For that, you need to patch action.yml

Thanks for the reply @thomaseizinger 🙏 , i have created another PR: #4. Happy to make any changes there as well if needed. If all good, you reckon that we can create a mini-release?

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants