Added option to manually request browser restart

[ramiloif]

Option to request Cluster to restart the browser manually.
Motivation: sometimes when Google Chrome is running too long the RAM usage is increases.
Restart chrome from time to time (for example every 1k jobs) may be handy.
I added an implementation for that.
Restart may be handy for other reasons too. (Update some data from data dir ...)
Implementation:
Added public abstract requestRestart(): void; to ConcurrencyImplementation
Relevant mostly to to SingleBrowserImplementation
But as SingleBrowserImplementation extends ConcurrencyImplementation I couldn't find a way not to put it in the interface.

I tested It against my use case and it worked.

[tenkuken]

How to install and using this ?

[ramiloif]

Hi @tenkuken
you can install it from my fork,
using: ( install pupeteer-cluster from my fork)
npm install git+https://github.com/ramiloif/puppeteer-cluster.git

Usage create the cluster with CONCURRENCY_PAGE or CONCURRENCY_CONTEXT
For example:
const cluster = await Cluster.launch({
concurrency: Cluster.CONCURRENCY_CONTEXT,
maxConcurrency: 2,
});

Then when you want to schedule browser restart just call
cluster. requestRestart ();

Please update here how is that working for you .

[tenkuken]

Unfortunately, i'm using CONCURRENCY_BROWSER for perbrowserOptions.
As i can see, it won't work.

Thank you for update.

[ramiloif]

But if you’re using CONCURRENCY_BROWSER why do you need this restart?
Isn’t it automatically starts new browser for each task?

[tenkuken]

I'm sorry, It is automatically starts new browser for each task.
so CONCURRENCY_BROWSER doesn't need this restart feature.
It's my mistake.

[StringKe]

I try to execute requestRestart a certain number of times in doWork(doWork function in cluster.ts), but it doesn’t seem to work.

 private async doWork() {
    const doneJob = this.allTargetCount - this.jobQueue.size() - this.workersBusy.length;
    if (doneJob > 0 && doneJob % this.options.queueLimit === 0) {
      if (this.options.queueLimitRestart) {
        // this.requestRestart();
        this.requestRestart();
        // await Promise.all(this.workers.map(async (worker) => await worker.browser.repair()));
        Logger.log('max loop restart cluster', 'Puppeteer Cluster');
      } else {
        throw new Error('Queue limit reached');
      }
    }

...