Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#704 - adding a running performance index #790

Conversation

lkj19zpdiDDe
Copy link
Contributor

@lkj19zpdiDDe lkj19zpdiDDe commented Mar 8, 2019

Calculate a running index.

@thomaschampagne thomaschampagne self-requested a review March 10, 2019 17:38
@thomaschampagne
Copy link
Owner

@lkj19zpdiDDe Thanks for this work! And sry for the delay of handling...

I'm currently on the code review of your pull request.

For my concern and understanding, where did you find the formulas for running index?

In global settings there's no helper/explanations if we click on (i) icon. Could you write the helper of your feature in a below comment? I will create the proper .md file in the project under: https://github.com/thomaschampagne/elevate/tree/develop/plugin/app/src/assets/option-helpers

Nice work !

Thanks!

@lkj19zpdiDDe
Copy link
Contributor Author

No problem! We're all busy. I'm also traveling for business and won't be back to my personal computer setup for development until May 29th or so.

As to the formula, @Chrisx68 provided it. Details on how he developed it are in the request thread - #704. I've also been using it and have found it to be predictive/good quality.

On the helper, I'm happy to do this once I'm back from my travel.

@lkj19zpdiDDe
Copy link
Contributor Author

lkj19zpdiDDe commented Jul 4, 2019

Alright, I've merged this with latests, and I've added the helper/tooltip.

@thomaschampagne thomaschampagne merged commit 27606e5 into thomaschampagne:develop Jul 6, 2019
@thomaschampagne
Copy link
Owner

It's merged! Thanks for your work !!

I improved some little things after your commits

@thomaschampagne
Copy link
Owner

A test build from today is available here: https://thomaschampagne.github.io/elevate/#/builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants