Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not allow selecting a chess piece with a not authorized move #45

Conversation

charley04310
Copy link
Contributor

@charley04310 charley04310 commented Dec 6, 2023

Do not allow piece selection when there is no authorized moves

Update select_cell method to avoid selecting not authorized select

Description

Especially for the first player, do not allow selecting a chess piece with a not authorized move.

Fixes # (#44 )

How Has This Been Tested?

Start game and try to select not authorized piece as main pieces.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@charley04310 charley04310 changed the title feat: do not allow selecting a chess piece with a not authorized move minor: do not allow selecting a chess piece with a not authorized move Dec 6, 2023
@thomas-mauran thomas-mauran changed the title minor: do not allow selecting a chess piece with a not authorized move fix: do not allow selecting a chess piece with a not authorized move Dec 7, 2023
@thomas-mauran thomas-mauran merged commit cdcb473 into thomas-mauran:main Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants