Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "escape" event to helper menu #43

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

charley04310
Copy link
Contributor

@charley04310 charley04310 commented Dec 6, 2023

Title

Add "escape" event to helper menu

Description

Add "escape" event to helper menu and remove some useless vec!

Fixes # (#42)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@thomas-mauran thomas-mauran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx !

@thomas-mauran thomas-mauran merged commit 572e3eb into thomas-mauran:main Dec 7, 2023
3 checks passed
@thomas-mauran thomas-mauran changed the title minor: add "escape" event to helper menu feat: add "escape" event to helper menu Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants