New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates a much smaller final docker image #41

Merged

thomas-mauran merged 1 commit into thomas-mauran:main from jhauris:main

Dec 6, 2023

Contributor

jhauris commented Dec 6, 2023

Create a much smaller run docker image

Description

The build docker image is over 1.5 GB, which is much larger than needed. This PR copies the built binary to a much smaller (80MB) image.

Checklist:

[X ] My code follows the style guidelines of this project
[ X] I have performed a self-review of my code
[ X] I have commented my code, particularly in hard-to-understand areas
[ X] I have made corresponding changes to the documentation
[ X] My changes generate no new warnings
[ X] I have added tests that prove my fix is effective or that my feature works
[ X] New and existing unit tests pass locally with my changes
[ X] Any dependent changes have been merged and published in downstream modules


          Creates a much smaller run image after building

20c96d8

jhauris changed the title ~~Creates a much smaller run image after building~~ Creates a much smaller final docker image

Owner

thomas-mauran commented Dec 6, 2023

Oops, I forgot multi staging 💀 thanks for your contribution !

thomas-mauran merged commit 5f5cd3d into thomas-mauran:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet