Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a problem under wp 3.4.2 #18

Merged
merged 1 commit into from
Nov 12, 2012
Merged

Conversation

rixtox
Copy link
Contributor

@rixtox rixtox commented Nov 11, 2012

I found there's a serious problem that it doesn't work under the new version of wordpress.

The hook should better to attached on 'wp_enqueue_scripts' than just 'wp', which will set the plugin to process before everything, and the queueing of scripts and stylesheets by theme is not done yet at the time.

Didn't test on older versions of wordpress, but those shall work as will.

@thom4parisot
Copy link
Owner

I think it was an inevitable move.

Some themes (like reported here http://wordpress.org/support/topic/plugin-wp-less-wp-34) enqueue their stuff at the latest moment.

I usually register stylesheets etc. on init event, which leads me to no problem, even with the latest WP version.

Anyway, I feel it's safer to postpone to the latest moment possible the compilation process, agreed.

thom4parisot pushed a commit that referenced this pull request Nov 12, 2012
Fixed a problem under wp 3.4.2
@thom4parisot thom4parisot merged commit 062772e into thom4parisot:master Nov 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants