cache: cache_include(): fix double put for cloned objects #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching to auto obj, a nl_object_put() was left inplace in cache_include(). This leads to a double reference drop of the cloned object, leading to use after free later or triggering an assert that the reference count went negative. Fixes: 831e986 ("cache: use the new _nl_auto_nl_object helper") Signed-off-by: Jonas Gorski <[email protected]>
thom311
pushed a commit
that referenced
this pull request
Dec 17, 2024
When switching to auto obj, a nl_object_put() was left inplace in cache_include(). This leads to a double reference drop of the cloned object, leading to use after free later or triggering an assert that the reference count went negative. Fixes: 831e986 ("cache: use the new _nl_auto_nl_object helper") Signed-off-by: Jonas Gorski <[email protected]> #416
|
thanks for the fix!! hm, this is pretty bad. I think I should do a 3.12 release soon, just for this. |
|
This only does something if you are using the v2 callback where the object is actually cloned, not sure how many actually do that aside from us (who also added it). |
|
I understood that it's only relevant with the v2 callback. But I don't have a clear picture who uses that. It was unnoticed since:
ok, then maybe no immediate hurry... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching to auto obj, a nl_object_put() was left inplace in cache_include(). This leads to a double reference drop of the cloned object, leading to use after free later or triggering an assert that the reference count went negative.
Fixes: 831e986 ("cache: use the new _nl_auto_nl_object helper")