Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C2xC2 extension with given discriminant #1712

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat: add C2xC2 extension with given discriminant #1712

merged 1 commit into from
Dec 27, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Dec 25, 2024

No description provided.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (7344274) to head (1ccb8e9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/FieldFactory/ab_exts.jl 72.97% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   75.97%   75.96%   -0.01%     
==========================================
  Files         361      361              
  Lines      114341   114377      +36     
==========================================
+ Hits        86868    86888      +20     
- Misses      27473    27489      +16     
Files with missing lines Coverage Δ
src/FieldFactory/ab_exts.jl 84.37% <72.97%> (+4.15%) ⬆️

... and 33 files with indirect coverage changes

@thofma thofma merged commit 83f49f5 into master Dec 27, 2024
18 checks passed
@thofma thofma deleted the th/c22 branch December 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant