Remove circular delegating factor -> factor #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have AbstractAlgebra.factor === Hecke.factor these days
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
- Coverage 76.00% 75.96% -0.04%
==========================================
Files 362 362
Lines 114378 114377 -1
==========================================
- Hits 86932 86892 -40
- Misses 27446 27485 +39
|
lgoettgens
approved these changes
Dec 11, 2024
|
@thofma automerge failed, one OscarCI test had a timeout (probably a fluke and just needs to be restarted?) |
I restarted the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have AbstractAlgebra.factor === Hecke.factor these days
Resolves oscar-system/Oscar.jl#4034