Solve triu #1697
Merged
Solve triu #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adaptive ratrec for dixon - dixon in "julia" - solve_left for odd dim
As a side this now has a chance or working
p = next_prime(400)
A = matrix(ZZ, p, p, [powermod(i-1, j-i, p) for j = 1:p for i=1:p]);
Hecke.example("Det.jl")
h = Det.DetS(A, do_hnf = true);
h = hnf(h);
this is MUCH faster in this example than even Magma, let alone our hnf.
The hnf_storjohann at least terminates reasonably - and not too shabby in
comparison with Magma
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
+ Coverage 76.01% 76.23% +0.22%
==========================================
Files 362 362
Lines 114328 116893 +2565
==========================================
+ Hits 86903 89115 +2212
- Misses 27425 27778 +353 |
fingolfin
reviewed
Dec 4, 2024
examples/Det.jl
Outdated
Comment on lines
714
to
715
| ccall((:fmpz_sub, Nemo.libflint), Cvoid, (Ptr{ZZRingElem}, Ptr{ZZRingElem}, Ptr{ZZRingElem}), R_ptr, R_ptr, U_ptr) | ||
| ccall((:fmpz_divexact, Nemo.libflint), Cvoid, (Ptr{ZZRingElem}, Ptr{ZZRingElem}, Ref{ZZRingElem}), R_ptr, R_ptr, m) |
There was a problem hiding this comment.
Suggested change
| ccall((:fmpz_sub, Nemo.libflint), Cvoid, (Ptr{ZZRingElem}, Ptr{ZZRingElem}, Ptr{ZZRingElem}), R_ptr, R_ptr, U_ptr) | |
| ccall((:fmpz_divexact, Nemo.libflint), Cvoid, (Ptr{ZZRingElem}, Ptr{ZZRingElem}, Ref{ZZRingElem}), R_ptr, R_ptr, m) | |
| sub!(R_ptr, R_ptr, U_ptr) | |
| divexact!(R_ptr, R_ptr, m) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.