Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saturation at large primes #1661

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: saturation at large primes #1661

merged 1 commit into from
Oct 25, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Oct 25, 2024

Use baby-step-giant-step algorithm for large primes to make
the complexity not linear in the order.

Before (saturating at ~2^25):

96.520001 seconds (56.86 k allocations: 120.018 GiB, 17.87% gc time)

With this PR:

2.726522 seconds (70.38 M allocations: 1.101 GiB, 30.02% gc time)

Use baby-step-giant-step algorithm for large primes to make
the complexity not linear in the order.
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (637902b) to head (508be8f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
+ Coverage   75.86%   75.97%   +0.10%     
==========================================
  Files         361      361              
  Lines      113719   113700      -19     
==========================================
+ Hits        86274    86383     +109     
+ Misses      27445    27317     -128     
Files with missing lines Coverage Δ
src/NumFieldOrd/NfOrd/Clgp/Saturate.jl 63.50% <100.00%> (+0.54%) ⬆️
src/NumFieldOrd/NfOrd/ResidueRingMultGrp.jl 82.02% <ø> (ø)

... and 34 files with indirect coverage changes

@thofma
Copy link
Owner Author

thofma commented Oct 25, 2024

@fieker happy?

@fieker fieker merged commit 34fb045 into master Oct 25, 2024
18 checks passed
@fieker fieker deleted the th/sat branch October 25, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants