Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version number, in order to allow for GAP.jl 0.12 #1628

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ThomasBreuer
Copy link
Contributor

@ThomasBreuer ThomasBreuer commented Sep 25, 2024

If Oscar.jl wants to use GAP.jl 0.12.0 then the Hecke.jl dependencies must allow GAP.jl 0.12 (see oscar-system/Oscar.jl/pull/4086).

@thofma
Copy link
Owner

thofma commented Sep 25, 2024

This indeed needs adjustments. What is the substitute for julia_to_gap?

@ThomasBreuer
Copy link
Contributor Author

One can call GapObj instead of julia_to_gap. I will adjust my pull request accordingly.
(Installing new methods for GapObj seems to be not needed in Hecke.jl.)

@thofma
Copy link
Owner

thofma commented Sep 25, 2024

Thanks. (Found it in the meantime and pushed a fix.)

@ThomasBreuer
Copy link
Contributor Author

As far as I see, there is one more GAP.julia_to_gap call in src/FieldFactory/CM_recognition.jl.

@thofma
Copy link
Owner

thofma commented Sep 25, 2024

thanks, I also missed another one

@thofma thofma merged commit cfbc336 into thofma:master Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants