Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power series as valuation rings #1592

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

joschmitt
Copy link
Collaborator

Some functionality for valuation rings of local fields in positive characteristic

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (6113eae) to head (f6c633b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/LocalField/PowerSeries.jl 96.47% 5 Missing ⚠️
src/LocalField/LaurentSeries.jl 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1592      +/-   ##
==========================================
+ Coverage   75.72%   75.75%   +0.02%     
==========================================
  Files         358      360       +2     
  Lines      113697   113894     +197     
==========================================
+ Hits        86092    86275     +183     
- Misses      27605    27619      +14     
Files with missing lines Coverage Δ
src/LocalField/ResidueRing.jl 99.03% <100.00%> (-0.41%) ⬇️
src/LocalField/Ring.jl 87.01% <100.00%> (+0.25%) ⬆️
src/LocalField/Types.jl 100.00% <100.00%> (ø)
src/Sparse/HNF.jl 70.39% <ø> (ø)
src/LocalField/LaurentSeries.jl 95.00% <95.00%> (ø)
src/LocalField/PowerSeries.jl 96.47% <96.47%> (ø)

... and 30 files with indirect coverage changes

@joschmitt
Copy link
Collaborator Author

That one OSCAR CI job keeps crashing in the book tests. I can't imagine that this is related to the changes here?

@thofma thofma merged commit b801de3 into thofma:master Sep 5, 2024
17 checks passed
@joschmitt joschmitt deleted the js/powerseries branch September 5, 2024 14:35
BD-00 pushed a commit to BD-00/Hecke.jl that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants