fix: sparse row additions #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 75.60% 75.78% +0.18%
==========================================
Files 358 358
Lines 113693 113696 +3
==========================================
+ Hits 85952 86164 +212
+ Misses 27741 27532 -209
|
BD-00
added a commit
to BD-00/Hecke.jl
that referenced
this pull request
Oct 6, 2024
fingolfin
added a commit
to fingolfin/Hecke.jl
that referenced
this pull request
Oct 23, 2024
Some issues in `add_scaled_row!` were fixed in thofma#1591, but not to `add_right_scaled_row!`. Rectify this by merging the two functions into one.
thofma
pushed a commit
that referenced
this pull request
Oct 25, 2024
Some issues in `add_scaled_row!` were fixed in #1591, but not to `add_right_scaled_row!`. Rectify this by merging the two functions into one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_scaled_row!saved zeros when working over residue rings, that should be fixed now.