Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare possible AbstractAlgebra deprecations #1589

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

joschmitt
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (ee980a7) to head (bd119ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NumField/NfRel/NfRelNSMor.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1589       +/-   ##
===========================================
+ Coverage    5.44%   75.69%   +70.24%     
===========================================
  Files         358      358               
  Lines      113490   113693      +203     
===========================================
+ Hits         6183    86059    +79876     
+ Misses     107307    27634    -79673     
Files with missing lines Coverage Δ
src/LocalField/Poly.jl 63.37% <ø> (+63.37%) ⬆️
src/NumField/NfRel/NfRelNSMor.jl 79.32% <75.00%> (+79.32%) ⬆️

... and 319 files with indirect coverage changes

@thofma thofma merged commit 6f950e5 into thofma:master Aug 29, 2024
16 of 17 checks passed
@joschmitt joschmitt deleted the js/cleanup branch September 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants