Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe fix 1509 #1511

Merged
merged 6 commits into from
May 16, 2024
Merged

Maybe fix 1509 #1511

merged 6 commits into from
May 16, 2024

Conversation

joschmitt
Copy link
Collaborator

My educated guess is that setprecision!(::CompletionMap, ...) should change the precision of the codomain (if any).

Related to #1509.

@joschmitt joschmitt requested a review from fieker May 15, 2024 15:55
@simonbrandhorst
Copy link
Collaborator

Could you please add a test?

@simonbrandhorst
Copy link
Collaborator

Note that constructing stuff with unramified_extension the setprecision! method still errors ... but it is internal and maybe I am not using it correctly so I would say that is a different issue.

@testset "Issue 1509" begin
  F, _ = cyclotomic_field(3)
  OF = maximal_order(F);
  K, toK = Hecke.unramified_completion(F, 2*OF);
  setprecision!(toK, 200)
  @test precision(toK(F(1))) == 200
end

@joschmitt
Copy link
Collaborator Author

Note that constructing stuff with unramified_extension the setprecision! method still errors ... but it is internal and maybe I am not using it correctly so I would say that is a different issue.

@testset "Issue 1509" begin
  F, _ = cyclotomic_field(3)
  OF = maximal_order(F);
  K, toK = Hecke.unramified_completion(F, 2*OF);
  setprecision!(toK, 200)
  @test precision(toK(F(1))) == 200
end

I don't think you are using it wrong... I try to fix it.

@joschmitt
Copy link
Collaborator Author

All of this is just guess work from my side. Obviously these functions did not work for some time, maybe they never did.

@thofma thofma merged commit f9a2779 into thofma:master May 16, 2024
18 checks passed
@joschmitt joschmitt deleted the js/fix1509 branch May 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants