experimentally: allow small hight lifts #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia> k, a = wildanger_field(3, 13) (Number field of degree 3 over QQ, _$) julia> c, mc = Hecke.unramified_completion(k, prime_ideals_over(maximal_order(k), 17)[1]) (Unramified extension of 17-adic numbers of degree 1, Map: k -> c) julia> preimage(mc, mc(a)) 2639044339939425523644123345123996041787685738888204449072451948418018872324117 julia> preimage(mc, mc(a); small_lift = true, integral = true) _$ julia> preimage(mc, mc(a^3//5-2); small_lift = true) 13//5*_$^2 - 13//5*_$ + 3//5 (and the same for plain completion) needs tests and polish, but Simon wanted to play
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
- Coverage 75.37% 75.36% -0.02%
==========================================
Files 354 354
Lines 112723 112811 +88
==========================================
+ Hits 84966 85021 +55
- Misses 27757 27790 +33
|
|
Thank you! (Edit: The example works now, it seems that revise did not update the type definition) |
|
Can someone supply an example? Then we can add a test and get this in. |
|
This seems to work for unramified extensions, but for ramified ones not. |
simonbrandhorst
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
julia> k, a = wildanger_field(3, 13)
(Number field of degree 3 over QQ, _$)
julia> c, mc = Hecke.unramified_completion(k, prime_ideals_over(maximal_order(k), 17)[1]) (Unramified extension of 17-adic numbers of degree 1, Map: k -> c)
julia> preimage(mc, mc(a))
2639044339939425523644123345123996041787685738888204449072451948418018872324117
julia> preimage(mc, mc(a); small_lift = true, integral = true) _$
julia> preimage(mc, mc(a^3//5-2); small_lift = true) 13//5*$^2 - 13//5*$ + 3//5
(and the same for plain completion)
needs tests and polish, but Simon wanted to play