Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add deprecations of #1455 #1474

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

lgoettgens
Copy link
Contributor

They were removed from #1455 to make it non-breaking.

This PR should be marked as breaking and only merged in the preparation of the 0.31.0 release.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (8048731) to head (8b7e47d).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1474      +/-   ##
==========================================
- Coverage   75.20%   75.19%   -0.01%     
==========================================
  Files         354      354              
  Lines      112687   112708      +21     
==========================================
+ Hits        84746    84756      +10     
- Misses      27941    27952      +11     
Files Coverage Δ
src/Deprecations.jl 100.00% <ø> (+100.00%) ⬆️

... and 53 files with indirect coverage changes

@thofma thofma merged commit 3538e86 into thofma:master May 1, 2024
29 of 34 checks passed
@lgoettgens lgoettgens deleted the lg/deprecate-Val branch May 1, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants