Sort out deprecations and aliases #1458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs Nemocas/Nemo.jl#1704 to be available, and the Nemo compat to be adapted accordingly.
This is an approach to sort deprecations and aliases as discussed with @fingolfin and already started in Nemocas/AbstractAlgebra.jl#1537 and Nemocas/Nemo.jl#1704.
There are some workarounds added to make this non-breaking for Oscar 1.0, that should get removed in the next minor release.
Things that have been changed:
ishermitian
)@include_deprecated_bindings()
from both AA and Nemo. The initial problem both of these approaches fix is that types that are deprecated using@deprecate_binding
are not re-exported (but should). @fingolfin and I found a macro the easiest way to execute the deprecations again in the Hecke scope (and once everything is updated in the Oscar scope as well).