Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace more uses of isFOO by is_foo #1270

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

fingolfin
Copy link
Contributor

No description provided.

@fingolfin
Copy link
Contributor Author

There is a failure in Run long tests / test (1.9, x64, macOS-latest) (pull_request) but I can't tell what it is / if it is related to this PR or not.

@thofma perhaps you could restart it? It would be nice to get this merged so I can proceed with the alias deprecations.

@fingolfin
Copy link
Contributor Author

@thofma it seems you already restarted it twice before and it keeps running into an infinite loop. So perhaps there is a genuine issue here? But what could that be? weird

@thofma
Copy link
Owner

thofma commented Nov 3, 2023

Nah, it is "normal".

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1270 (809b699) into master (0fd09c1) will increase coverage by 67.82%.
Report is 4 commits behind head on master.
The diff coverage is 85.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1270       +/-   ##
===========================================
+ Coverage    6.62%   74.45%   +67.82%     
===========================================
  Files         346      346               
  Lines      111179   111321      +142     
===========================================
+ Hits         7370    82879    +75509     
+ Misses     103809    28442    -75367     
Files Coverage Δ
src/AlgAss/AbsAlgAss.jl 91.71% <100.00%> (+91.71%) ⬆️
src/AlgAss/Ramification.jl 100.00% <100.00%> (+100.00%) ⬆️
src/EllCrv/EllCrv.jl 95.57% <100.00%> (+95.57%) ⬆️
src/EllCrv/Heights.jl 92.43% <100.00%> (+92.43%) ⬆️
src/EllCrv/LocalData.jl 89.59% <100.00%> (+89.59%) ⬆️
src/EllCrv/ModularPolynomials.jl 100.00% <100.00%> (+100.00%) ⬆️
src/EllCrv/Torsion.jl 90.46% <100.00%> (+90.46%) ⬆️
src/GrpAb/GrpAbFinGen.jl 80.29% <100.00%> (+78.52%) ⬆️
src/HypellCrv/HypellCrv.jl 82.70% <100.00%> (+82.70%) ⬆️
src/Misc/Poly.jl 62.11% <100.00%> (+50.91%) ⬆️
... and 9 more

... and 286 files with indirect coverage changes

@thofma thofma merged commit c4b9e50 into thofma:master Nov 3, 2023
16 of 18 checks passed
@fingolfin fingolfin deleted the mh/rename branch November 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants