Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isupper_triangular -> is_upper_triangular, isunit -> is_unit #1265

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

fingolfin
Copy link
Contributor

The former name has been "deprecated" for a long time now.

The former name has been "deprecated" for a long time now.
@fingolfin fingolfin changed the title isupper_triangular -> is_upper_triangular isupper_triangular -> is_upper_triangular, isunit -> is_unit Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1265 (36aee56) into master (6dcd2c8) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   74.47%   74.50%   +0.03%     
==========================================
  Files         346      346              
  Lines      111320   111323       +3     
==========================================
+ Hits        82900    82944      +44     
+ Misses      28420    28379      -41     
Files Coverage Δ
src/AlgAssAbsOrd/Ideal.jl 74.91% <100.00%> (ø)
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.30% <100.00%> (ø)
src/AlgAssAbsOrd/UnitGroup.jl 58.03% <100.00%> (ø)
src/LocalField/Completions.jl 77.87% <100.00%> (ø)
src/Misc/Matrix.jl 75.75% <100.00%> (ø)
src/NumFieldOrd/NfOrd/Clgp/FacBase_Euc.jl 73.62% <100.00%> (ø)
src/Sparse/Matrix.jl 71.44% <100.00%> (ø)
src/Sparse/Solve.jl 85.97% <100.00%> (ø)
src/AlgAssAbsOrd/PIP.jl 50.68% <0.00%> (-0.06%) ⬇️
src/Sparse/HNF.jl 70.83% <66.66%> (ø)
... and 1 more

... and 26 files with indirect coverage changes

@fingolfin
Copy link
Contributor Author

The OscarCI failures seems to be due to an issue with the Julia package servers

@thofma thofma merged commit 159ba41 into thofma:master Oct 31, 2023
15 of 18 checks passed
@fingolfin fingolfin deleted the mh/rename branch October 31, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants