Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dot(x, A, y) for sparse matrices #1263

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

felix-roehrich
Copy link
Contributor

This PR adds the following dispatches

dot(x::SRow{T}, A::SMat{T}, y::SRow{T}) where T
dot(x::MatrixElem{T}, A::SMat{T}, y::MatrixElem{T}) where T
dot(x::AbstractVector{T}, A::SMat{T}, y::AbstractVector{T}) where T

If you have any suggestions for improvements, let me know.

src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
src/Sparse/Matrix.jl Outdated Show resolved Hide resolved
@thofma
Copy link
Owner

thofma commented Oct 28, 2023

@lgoettgens maybe you also want to have an artificial look? Since you also implemented a few things recently.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1263 (4d17e80) into master (787d345) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   74.55%   74.47%   -0.08%     
==========================================
  Files         346      346              
  Lines      111273   111320      +47     
==========================================
- Hits        82962    82910      -52     
- Misses      28311    28410      +99     
Files Coverage Δ
src/Sparse/Matrix.jl 71.44% <100.00%> (+1.84%) ⬆️

... and 26 files with indirect coverage changes

@thofma
Copy link
Owner

thofma commented Oct 28, 2023

Yes, but please use nrows and ncols functions.

@felix-roehrich felix-roehrich requested a review from thofma October 28, 2023 14:17
@thofma thofma merged commit 6dcd2c8 into thofma:master Oct 28, 2023
16 of 18 checks passed
@thofma
Copy link
Owner

thofma commented Oct 28, 2023

Do you want a quick release to use it in Oscar?

@felix-roehrich
Copy link
Contributor Author

Do you want a quick release to use in Oscar?

Thank you, but this is not necessary.

@felix-roehrich felix-roehrich deleted the fr/sparse-dot-3arg branch October 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants