Fix kronecker_product(::SMat, ::SMat)
#1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you bump the version in the PR, it will be even faster. |
|
The failed 1.9-macOS job seems to be unrelated to the change |
|
Not sure why the "long tests" are failing so often, but once they succeed I will merge. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
===========================================
+ Coverage 6.56% 74.48% +67.91%
===========================================
Files 346 346
Lines 111157 111298 +141
===========================================
+ Hits 7303 82902 +75599
+ Misses 103854 28396 -75458
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another nasty bug in that function. I added the example that confused me as a test.
I am looking forward to a fast merge and release of this so that I can use it in oscar-system/Oscar.jl#2936.